Skip to content

V2 OV: register a new Organization Representative from template parameters - #42

Merged
spbsoluble merged 2 commits into
feat/v2-spec-followupsfrom
feat/v2-ov-org-representative
Nov 17, 2026
Merged

spbsoluble merged 2 commits into
feat/v2-spec-followupsfrom
feat/v2-ov-org-representative

Conversation

@spbsoluble

@spbsoluble spbsoluble commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

V2 OV orders can register a new Organization Representative from template parameters.

Features

  • New template parameters (V2, OV only): OrgRepresentativeName, OrgRepresentativeEmail, OrgRepresentativePhone, OrgRepresentativeDesignation, OrgRepresentativeEmployeeId.
    • With Name and Email set, the order registers the new representative.
    • Without them, the OV request is unchanged.
  • Checks at template save and before any CA call:
    • OV only.
    • The connector needs OrganizationNumber.
    • Name and email must both be set, and the email must look valid.
    • The phone needs 6-15 digits.
    • Error messages name the parameter, never its value.
  • Logging: the plugin logs the representative status CERTInext returns (applied or pending-approval).
  • V1 and reissue: V1 ignores the parameters, with a warning at save. A V2 reissue doesn't send them.

Fixes

  • Emails in V2 error bodies: emails inside CA error text in logged V2 error bodies are now masked. Before, only the exception message was masked, so an EMS-1317 error could log the representative's email.
  • Personal-data redaction: now also covers employeeId and the representative blocks.

Testing

  • Unit tests: 1333 passed (37 new), and 1252 with DcvSupport=false.
  • Release builds: 0 warnings in both configs.
  • New tests:
    • The validation rules and the phone rule.
    • The exact request JSON, and an unchanged request without a representative.
    • DV and EV rejected before any CA call.
    • No representative values in any log line.
    • Masking of an echoed email in a 422 error.

Other

spbsoluble and others added 2 commits November 15, 2026 12:19
… parameters

OrgRepresentativeName/Email (together) plus optional Phone/Designation/EmployeeId send
organization.useNewOrgRepresentative=true with an organizationRepresentative block on
a V2 OV create. ValidateProductInfo and EnrollV2CoreAsync share one check that mirrors
CERTInext's rules before any CA call: OV only (EMS-1315), a pre-vetted organization
(EMS-1316), name and email together (EMS-1319/1320), one email, phone 6-15 digits
(EMS-1321). Error messages name parameters, never values. V1 ignores them (warns at
save); a reissue doesn't send them. The create response's
organizationRepresentativeStatus is logged; pendingOrganizationRepresentative is kept
raw (undocumented shape) and only its presence logged.

Personal data: employeeId and the block keys join PersonalOtherFieldNames, and emails
inside CA error text (detail/title/message/errorMessage) in logged bodies are now
masked; an EMS-1317 error echoing the representative's email used to reach the
Warning-level V2 non-success line unmasked.
@spbsoluble
spbsoluble merged commit 087554f into feat/v2-spec-followups Nov 17, 2026
@spbsoluble
spbsoluble deleted the feat/v2-ov-org-representative branch November 17, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant